Run lint in all folders #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alopalao
commented
Jul 24, 2024
| @@ -114,8 +115,14 @@ class TestCoverage(Test): | |||
|
|
|||
| def run(self): | |||
| """Run unittest quietly and display coverage report.""" | |||
| cmd = f"python3 -m pytest --cov=. tests/ {self.get_args()}" | |||
| call(cmd, shell=True) | |||
| cmd = "python3 -m pytest --cov=. tests/ --cov-report term-missing" | |||
There was a problem hiding this comment.
Related to kytos issue #487
Yes, appreciated you double checking @Alopalao, I turns out I had an older branch that was with py39 for the local dev of this NApp. But, I'm glad you took the opportunity to also fix the adjacent parts here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34
Summary
Added all the folders containing python scripts to be inspected by lint
Local Tests
Run tox
End-to-End Tests
N/A